C#: Prepend enclosing method in local function TRAP labels#2061
Merged
Conversation
hvitved
force-pushed
the
csharp/local-function-label
branch
from
322ddde to
413926f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the underlying issue of #2018. The issue was closed, because the false positive was no longer there following the latest dist upgrade. However, it turns out that the bug was merely hidden (by #1851), and then revealed again with #2054.
The underlying problem is that if a file gets compiled twice, into assemblies
A.dllandB.dll, then all methods in the file will exist in two copies (by design), as the method labels are prefixed withAandB. However, local functions do not contain the assembly prefix, so -- because of the TRAP stack -- only the firstly imported TRAP file will get a copy of the local function. The solution is to prepend the ID of the enclosing callable when generating TRAP labels for local functions, in order to also get a copy per assembly.